Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zbranch #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Zbranch #14

wants to merge 3 commits into from

Conversation

scientist1642
Copy link

Hi, added simple logging with tensorboard logger. (no dependencies on tensorflow)
If you want to keep it simple and minimal it's ok to reject :)
training time here is around 10 hours.
example

@ethancaballero
Copy link
Contributor

ethancaballero commented Mar 30, 2017

did you update to v0.1.11 ? I noticed threads kept dropping until I upgraded to v0.1.11 which was released today.

@scientist1642
Copy link
Author

No I'm on 0.1.10+3eab8a7, were threads dropping on this branch?

@ethancaballero
Copy link
Contributor

Threads were dropping with version 0.1.10+2fd4d08. Threads no longer drop with version 0.1.11+8aa1cef

@ikostrikov
Copy link
Owner

ikostrikov commented Mar 30, 2017

Looks good to me!

Could you please squash commits into one (or 2-3) and use a message like "Add tensorboard logging" and I will accept a PL?

ikostrikov2 and others added 3 commits March 30, 2017 19:01
Add debug flag to run in debug mode (useful for gdb) and use logger
instead of print.
@ikostrikov
Copy link
Owner

Thanks! Are you planning to change anything or I can merge the PL?

@scientist1642
Copy link
Author

👍 For now not, If I notice something beneficial, we can have another discussion.

@ikostrikov
Copy link
Owner

Hi, sorry for delays (was busy with the NIPS deadline). I will review asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants